Hi Omar, Everything looks good. On 2/27/19, 1:50 PM, "Omar Sandoval" <osandov@xxxxxxxxxxx> wrote: On Wed, Feb 20, 2019 at 08:42:40PM -0800, Chaitanya Kulkarni wrote: > Hi Omar, > This is a small patch series which follows the blktests coding > style format as pointed out by Bart. Also minimizes the overall > code for the review. > > -Regards, > Chaitanya > > Changes since V1:- > 1. Add testcase specific error message on failure. I also made these redirect to $FULL instead of /dev/null. The result is pushed to https://github.com/osandov/blktests/commits/nvme-cleanups, could you take a quick look? Also, I assume I can add your signed-off-by to all of these commits? Yes, feel free to add that.