Re: [PATCH] block: optimize bvec iteration in bvec_iter_advance

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 28/02/2019 17:00, Christoph Hellwig wrote:
> There is no need to only iterate in chunks of PAGE_SIZE or less in
> bvec_iter_advance, given that the callers pass in the chunk length that
> they are operating on - either that already is less than PAGE_SIZE
                           this? ^
> because they do classic page-based iteration, or it is larger because
> the caller operates on multi-page bvecs.
> 
> This should help optimizing shaving off a few cycles of the I/O hot

optimizing || shaving off, both together sounds awkward.

Otherwise
Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx>

-- 
Johannes Thumshirn                            SUSE Labs Filesystems
jthumshirn@xxxxxxx                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux