On 2/27/19 8:41 AM, Ming Lei wrote: > On Wed, Feb 27, 2019 at 06:25:30AM -0700, Jens Axboe wrote: >> On 2/27/19 5:40 AM, Ming Lei wrote: >>> Hi, >>> >>> The 1st patch introduce bvec_nth_page(), so that nth_page() can >>> be avoided if the bvec is single-page. >>> >>> The 2nd and 3rd patch adds fast path for single-page bvec case. >>> >>> The last patch introduces a light-weight helper for iterating over >>> pages, which may improve __bio_iov_bvec_add_pages(). This patch >>> is for io_uring. >> >> This reclaims another 2%, we're now at 1585K for the test case. >> Definite improvement! > > BTW, could you test the following patch against the 4 patches? No noticable difference with this one, though it looks like an improvement from a code inspection point of view. -- Jens Axboe