On Mon, 2019-02-18 at 10:53 -0800, Chaitanya Kulkarni wrote: +AD4 Signed-off-by: Chaitanya Kulkarni +ADw-chaitanya.kulkarni+AEA-wdc.com+AD4 +AD4 --- +AD4 tests/nvme/017 +AHw 5 +-+-+-+-- +AD4 tests/nvme/017.out +AHw 11 ----------- +AD4 2 files changed, 4 insertions(+-), 12 deletions(-) +AD4 +AD4 diff --git a/tests/nvme/017 b/tests/nvme/017 +AD4 index 0b86bec..db87759 100755 +AD4 --- a/tests/nvme/017 +AD4 +-+-+- b/tests/nvme/017 +AD4 +AEAAQA -37,7 +-37,10 +AEAAQA test() +AHs +AD4 port+AD0AIgAk(+AF8-create+AF8-nvmet+AF8-port +ACI-loop+ACI)+ACI +AD4 +AF8-add+AF8-nvmet+AF8-subsys+AF8-to+AF8-port +ACIAJAB7-port+AH0AIg +ACIAJAB7-subsys+AF8-name+AH0AIg +AD4 +AD4 - nvme discover -t loop +AHw sed -r -e +ACI-s/portid: +AFs-0-9+AF0AKw-/portid: X/+ACI +AD4 +- nvme discover -t loop +AHw grep -q +ACIAJAB7-subsys+AF8-nqn+AH0AIg +AD4 +- if +AFs +ACQ? -ne 0 +AF0AOw then +AD4 +- echo +ACI-nvme discover command failed+ACI +AD4 +- fi Hi Chaitanya, Please keep the code style consistent with other blktests code and write that if-condition as follows: if +ACE nvme discover -t loop +AHw grep -q +ACIAJAB7-subsys+AF8-nqn+AH0AIgA7 then echo +ACI-nvme discover command failed+ACI fi Thanks, Bart.
