On Mon, Feb 04, 2019 at 07:04:15AM -0800, Christoph Hellwig wrote: > On Fri, Feb 01, 2019 at 09:50:07PM +0100, David Kozub wrote: > > This patch series extends SED OPAL support: it adds IOCTL for setting the shadow > > MBR done flag which can be useful for unlocking an OPAL disk on boot and it adds > > IOCTL for writing to the shadow MBR. Also included are some minor fixes and > > improvements. > > Actually most of it is really useful cleanups and small fixes for the > existing OPAL code. Any chance you could resend just those bits as > a first series ASAP? I'll try to spend some time to to review the > actual feature additions in the meantime. > > > There is a fork of sed-opal-temp that can use these new IOCTLs.[2] I tested > > these on Samsung 840 EVO and 850 EVO drives, on x86-64 and arm64 systems. > > Which brings up another question: how do we get a properly maintained > version of the sed-opal tool up ASAP? It's been a bit bitrotting > unfortunately, and the documentation and error handling hasn't been all > that great to start with. Are we going to find a good home for it? > Util-linux for example? I would also like to get it off my github and into a proper location as well. Christoph, do you know off hand how we would get it in util-linux?