On Fri, Feb 01, 2019 at 09:50:09PM +0100, David Kozub wrote: > From: Jonas Rabenstein <jonas.rabenstein@xxxxxxxxxxxxxxxxxxxxxxx> > > Also the values of OPAL_UID_LENGTH and OPAL_METHOD_LENGTH are the same, > it is weird to use OPAL_UID_LENGTH for the definition of the methods. > > Signed-off-by: Jonas Rabenstein <jonas.rabenstein@xxxxxxxxxxxxxxxxxxxxxxx> > Reviewed-by: Scott Bauer <sbauer@xxxxxxxxxxxxxx> Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> Dave, when you resubmit other peoples patches you should also add your Signed-off-by: line to the end of the signoff chain.