On Wed, Jan 30, 2019 at 10:44:24AM +0100, Hannes Reinecke wrote: > The 'response' buffer from bsg is mapped onto the SCSI sense buffer, > however after commit 82ed4db499b8 we need to allocate them ourselves > as the bsg queue is _not_ a SCSI queue, and hence the sense buffer > won't be allocated from the scsi stack. I don't think this is the full story. Plain old bsg nodes are on SCSI (or legacy IDE) request queues, so this should be initialized, and your patch creates a memory leak by overwriting the sense pointer. bsg-lib nodes aren't on scsi request queues, but they don't use the code path your patch to start with. What exactly is the reproducer for this problem?
