On 1/29/19 8:38 AM, Jann Horn wrote: > On Tue, Jan 29, 2019 at 2:35 PM Jens Axboe <axboe@xxxxxxxxx> wrote: >> >> On 1/29/19 5:12 AM, Florian Weimer wrote: >>> * Jens Axboe: >>> >>>> +#define IORING_MAX_ENTRIES 4096 >>> >>> Where does this constant come from? Should it really be exposed to >>> userspace? >> >> Seems pretty handy for the application to know what the limit is? > > The running kernel version might be different from the kernel version > whose headers the userspace code was compiled with. So if this is a > limit that might change at some point in the future, and you think > userspace wants to know the limit, some other API might be better. Probably best to just kill it, we'll error in io_uring_register() if it's exceeded anyway. -- Jens Axboe
