On 1/28/19 2:53 PM, Jeff Moyer wrote: > Jens Axboe <axboe@xxxxxxxxx> writes: > >> +static int __io_uring_enter(struct io_ring_ctx *ctx, unsigned to_submit, >> + unsigned min_complete, unsigned flags, >> + const sigset_t __user *sig, size_t sigsz) >> +{ >> + int submitted, ret; >> + >> + submitted = ret = 0; >> + if (to_submit) { >> + submitted = io_ring_submit(ctx, to_submit); >> + if (submitted < 0) >> + return submitted; >> + } >> + if (flags & IORING_ENTER_GETEVENTS) { > > Do we want to disallow any unsupported flags? Yes good point, we do that in other spots. Fixed. -- Jens Axboe