On Tue, Jan 22, 2019 at 11:31:31PM +0100, David Kozub wrote: > This patch series extends OPAL support: it adds IOCTL for setting the shadow > MBR done flag which can be useful for unlocking an OPAL disk on boot and it adds > IOCTL for writing to the shadow MBR. Also included are some minor fixes and > improvements. > > This series is based on the original work done by Jonas Rabenstein which was > submitted in March 2018.[1] I tried to apply suggestions made in review on the > list and do some further improvements. > > The most contentious issue in the original series was the IOCTL for shadow MBR > write but I think no better approach was found[2] so this was not changed. I'm > open to suggestions. > > There is a fork of sed-opal-temp that can use these new IOCTLs.[3] I tested > these on Samsung 840 EVO and 850 EVO drives, on x86-64 and arm64 systems. > > The series applies on v5.0-rc3. > > Changes from v2 to v3: > * review suggestions from Scott Bauer > > As Scott suggested I tried to do a more thorough testing, esp. with things like > wrong passwords/invalid values. I did not observe any crash or unexpected > behavior. > > David Kozub (8): > block: sed-opal: fix typos and formatting > block: sed-opal: close parameter list in cmd_finalize > block: sed-opal: unify cmd start > block: sed-opal: unify error handling of responses > block: sed-opal: reuse response_get_token to decrease code duplication > block: sed-opal: pass steps via argument rather than via opal_dev > block: sed-opal: don't repeat opal_discovery0 in each steps array > block: sed-opal: rename next to execute_steps > You forgot to send 16/16 again in v3. I pulled and tested off your github page. If you send a v4 or just resend that patch you can add my reviewed-by, as I reviewed it on my tree/from your github.
