On Sat, 19 Jan 2019, Scott Bauer wrote:
On Thu, Jan 17, 2019 at 09:31:40PM +0000, David Kozub wrote:
There is a fork of sed-opal-temp that can use these new IOCTLs.[3] I tested
these on Samsung 840 EVO and 850 EVO drives, on x86-64 and arm64 systems.
Generally the series looks fine. Can you please, do some more sanity testing on
error conditions? Unlock with bad password, try and set up LR with bad PW, or
too large of a LR, like 242 or something. This series really changes the core
portion of this driver that essentially makes all this run and it looks like all
the normal conditions are fine, but im worried about some error conditions.
Resend V3 and I'll do some sanity tests on my end once I find my one nvme drive
with opal support.
Hi Scott,
Thank you for the review! I will apply your suggestions and then I try to
do more tests. After that I submit V3.
Best regards,
David
