On 1/16/19 6:31 PM, Jeff Moyer wrote: > Jens Axboe <axboe@xxxxxxxxx> writes: > >> On 1/16/19 5:50 PM, Jeff Moyer wrote: >>> Hi, Jens, >>> >>> It looks to me like calling io_uring_register more than once (for either >>> IORING_REGISTER_BUFFERS or IORING_REGISTER_FILES) will leak the >>> references taken in previous calls. >> >> Oops, thanks for that. Let's make it -EBUSY though, everything ends up >> being -EINVAL and that sometimes makes it hard for an application to >> figure out wtf is going on. > > Sounds good. > >> I also added -EINVAL for unregister when not already setup. > > Yep, I saw that. Changed it to -ENXIO, that's more descriptive. -- Jens Axboe
