On Fri, 2019-01-04 at 12:06 -0500, John Pittman wrote: +AD4 If the kernel is built without CONFIG+AF8-BLK+AF8-DEV+AF8-ZONED, a modprobe +AD4 of the null+AF8-blk driver with zoned+AD0-1 fails with 'Invalid argument'. +AD4 This can be confusing to users, prompting a search as to why the +AD4 parameter is invalid. To assist in that search, add a bit more +AD4 information to the failure, additionally adding to the documentation +AD4 that CONFIG+AF8-BLK+AF8-DEV+AF8-ZONED is needed for zoned+AD0-1. +AD4 +AD4 Signed-off-by: John Pittman +ADw-jpittman+AEA-redhat.com+AD4 +AD4 --- +AD4 Documentation/block/null+AF8-blk.txt +AHw 3 +-+-- +AD4 drivers/block/null+AF8-blk.h +AHw 1 +- +AD4 2 files changed, 3 insertions(+-), 1 deletion(-) +AD4 +AD4 diff --git a/Documentation/block/null+AF8-blk.txt b/Documentation/block/null+AF8-blk.txt +AD4 index ea2dafe49ae8..4cad1024fff7 100644 +AD4 --- a/Documentation/block/null+AF8-blk.txt +AD4 +-+-+- b/Documentation/block/null+AF8-blk.txt +AD4 +AEAAQA -88,7 +-88,8 +AEAAQA shared+AF8-tags+AD0AWw-0/1+AF0: Default: 0 +AD4 +AD4 zoned+AD0AWw-0/1+AF0: Default: 0 +AD4 0: Block device is exposed as a random-access block device. +AD4 - 1: Block device is exposed as a host-managed zoned block device. +AD4 +- 1: Block device is exposed as a host-managed zoned block device. Requires +AD4 +- CONFIG+AF8-BLK+AF8-DEV+AF8-ZONED. +AD4 +AD4 zone+AF8-size+AD0AWw-MB+AF0: Default: 256 +AD4 Per zone size when exposed as a zoned block device. Must be a power of two. +AD4 diff --git a/drivers/block/null+AF8-blk.h b/drivers/block/null+AF8-blk.h +AD4 index b3df2793e7cd..cab4808f14bd 100644 +AD4 --- a/drivers/block/null+AF8-blk.h +AD4 +-+-+- b/drivers/block/null+AF8-blk.h +AD4 +AEAAQA -97,6 +-97,7 +AEAAQA void null+AF8-zone+AF8-reset(struct nullb+AF8-cmd +ACo-cmd, sector+AF8-t sector)+ADs +AD4 +ACM-else +AD4 static inline int null+AF8-zone+AF8-init(struct nullb+AF8-device +ACo-dev) +AD4 +AHs +AD4 +- pr+AF8-err(+ACI-CONFIG+AF8-BLK+AF8-DEV+AF8-ZONED not enabled+AFw-n+ACI)+ADs +AD4 return -EINVAL+ADs +AD4 +AH0 +AD4 static inline void null+AF8-zone+AF8-exit(struct nullb+AF8-device +ACo-dev) +AHsAfQ Reviewed-by: Bart Van Assche +ADw-bvanassche+AEA-acm.org+AD4
