On Wed, Jan 2, 2019 at 10:07 AM Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> Stop this craziness. The optimization is garbage. If you want to save
> 15 cycles, get rid of code, don't add new code in an area where the
> block maintainers have already shown that they can't get it right.
Side note: that argument is further strengthened by a very simple
observation: if the code isn't going to sleep, then the whole state
setting is entirely and utterly pointless.
So code like this:
+ if (is_poll)
+ __set_current_state(TASK_UNINTERRUPTIBLE);
is *FUNDAMENTAL* garbage.
Seriously, stop playing stupid games. You're doing things wrong.
I'm doing to revert that buggy commit, and I will not pull any crazy
code that tries to redo this kind of completely broken code.
Linus
