On Thu, 2018-12-20 at 14:00 -0700, Jens Axboe wrote: +AD4 On 12/20/18 1:56 PM, Bart Van Assche wrote: +AD4 +AD4 +AEAAQA -96,6 +-97,9 +AEAAQA static void blk+AF8-mq+AF8-check+AF8-inflight(struct blk+AF8-mq+AF8-hw+AF8-ctx +ACo-hctx, +AD4 +AD4 +AHs +AD4 +AD4 struct mq+AF8-inflight +ACo-mi +AD0 priv+ADs +AD4 +AD4 +AD4 +AD4 +- if (rq-+AD4-q +ACEAPQ mi-+AD4-q) +AD4 +AD4 +- return+ADs +AD4 +AD4 Aren't you back to square one with this one, if the tags are shared? You +AD4 can't dereference it before you know it matches. My patch can only work if the new rq-+AD4-q +AD0 NULL assignment in +AF8AXw-blk+AF8-mq+AF8-free+AF8-request() is executed before the request tag is freed and if freeing a tag does not happen concurrently with any bt+AF8-iter() call. Would you accept that I add a seqlock to avoid this scenario? Thanks, Bart.
