On Tue, Dec 18, 2018 at 05:57:06PM +0100, Christoph Hellwig wrote: > > > On Mon, Dec 17, 2018 at 08:51:37PM -0800, yupeng wrote: > > Export bellow three functions: > > nvme_trace_parse_admin_cmd > > nvme_trace_parse_nvm_cmd > > nvme_trace_disk_name > > Thus any other modules which depends on nvme-core could use the trace > > events in trace.h > > But we don't actually use these trace events anywhere outside of core.c, > even with your second patch, do we? Except for nvme_trace_disk_name, which is used via __print_disk_name.