On Sun, Dec 16, 2018 at 05:16:50PM +0100, Christoph Hellwig wrote: > On Sun, Dec 16, 2018 at 10:25:16AM +0800, Ming Lei wrote: > > This patch sets map->nr_queues as zero explictly if there is zero > > queues for such queue type, then blk_mq_map_swqueue() can become > > more robust to deal with shared mappings. > > This looks a lot more clumsy than what we had before, can you explain > what additional robustnes it buys us? If there isn't one mapping type, its .nr_queues is set as zero explicitly, then we don't need to touch the related hctx/ctx which is retrieved via the shared mapping table. thanks, Ming