On Fri, 2018-12-14 at 19:39 +-0800, Ming Lei wrote: +AD4 This information is helpful to either investigate issues, or understand +AD4 wbt's internal behaviour. +AD4 +AD4 Cc: Bart Van Assche +ADw-bart.vanassche+AEA-wdc.com+AD4 +AD4 Cc: Omar Sandoval +ADw-osandov+AEA-fb.com+AD4 +AD4 Cc: Christoph Hellwig +ADw-hch+AEA-lst.de+AD4 +AD4 Cc: Josef Bacik +ADw-josef+AEA-toxicpanda.com+AD4 +AD4 Signed-off-by: Ming Lei +ADw-ming.lei+AEA-redhat.com+AD4 +AD4 --- +AD4 block/blk-wbt.c +AHw 91 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+- +AD4 1 file changed, 91 insertions(+-) +AD4 +AD4 diff --git a/block/blk-wbt.c b/block/blk-wbt.c +AD4 index 463e4eb80287..2684bf2d112f 100644 +AD4 --- a/block/blk-wbt.c +AD4 +-+-+- b/block/blk-wbt.c +AD4 +AEAAQA -715,6 +-715,94 +AEAAQA void wbt+AF8-disable+AF8-default(struct request+AF8-queue +ACo-q) +AD4 +AH0 +AD4 EXPORT+AF8-SYMBOL+AF8-GPL(wbt+AF8-disable+AF8-default)+ADs +AD4 +AD4 +-+ACM-ifdef CONFIG+AF8-BLK+AF8-DEBUG+AF8-FS +AD4 +-static int wbt+AF8-curr+AF8-window+AF8-show(void +ACo-data, struct seq+AF8-file +ACo-m) +AD4 +-+AHs +AD4 +- struct rq+AF8-qos +ACo-rqos +AD0 data+ADs +AD4 +- struct rq+AF8-wb +ACo-rwb +AD0 RQWB(rqos)+ADs +AD4 +- +AD4 +- seq+AF8-printf(m, +ACIAJQ-llu ns+AFw-n+ACI, rwb-+AD4-cur+AF8-win+AF8-nsec)+ADs +AD4 +- return 0+ADs +AD4 +-+AH0 Please consider to embed the unit (+ACI-ns+ACI) in the attribute name instead of in the attribute value. That will make it easier to process this attribute in developer debug scripts. +AD4 +-static int wbt+AF8-min+AF8-latency+AF8-show(void +ACo-data, struct seq+AF8-file +ACo-m) +AD4 +-+AHs +AD4 +- struct rq+AF8-qos +ACo-rqos +AD0 data+ADs +AD4 +- struct rq+AF8-wb +ACo-rwb +AD0 RQWB(rqos)+ADs +AD4 +- +AD4 +- seq+AF8-printf(m, +ACIAJQ-luns+AFw-n+ACI, rwb-+AD4-min+AF8-lat+AF8-nsec)+ADs +AD4 +- return 0+ADs +AD4 +-+AH0 Same comment here about the unit. +AD4 +-static const struct blk+AF8-mq+AF8-debugfs+AF8-attr wbt+AF8-debugfs+AF8-attrs+AFsAXQ +AD0 +AHs +AD4 +- +AHsAIg-curr+AF8-window+ACI, 0400, wbt+AF8-curr+AF8-window+AF8-show+AH0, +AD4 +- +AHsAIg-enable+AF8-state+ACI, 0400, wbt+AF8-enable+AF8-state+AF8-show+AH0, How about using +ACI-enabled+ACI instead of +ACI-enable+AF8-state+ACI? Thanks, Bart.
