On 2018/12/11 21:08, Shin'ichiro Kawasaki wrote:
> null_blk_zoned creation fails if the number of zones specified is equal to or is
> smaller than 64 due to a memory allocation failure in blk_alloc_zones(). With
> such a small number of zones, the required memory size for all zones descriptors
> fits in a single page, and the page order for alloc_pages_node() is zero. Allow
> this value in blk_alloc_zones() for the allocation to succeed.
>
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>
> ---
> block/blk-zoned.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-zoned.c b/block/blk-zoned.c
> index 13ba2011a306..a327bef07642 100644
> --- a/block/blk-zoned.c
> +++ b/block/blk-zoned.c
> @@ -378,7 +378,7 @@ static struct blk_zone *blk_alloc_zones(int node, unsigned int *nr_zones)
> struct page *page;
> int order;
>
> - for (order = get_order(size); order > 0; order--) {
> + for (order = get_order(size); order >= 0; order--) {
> page = alloc_pages_node(node, GFP_NOIO | __GFP_ZERO, order);
> if (page) {
> *nr_zones = min_t(unsigned int, *nr_zones,
>
Reviewed-by: Damien Le Moal <damien.lemoal@xxxxxxx>
--
Damien Le Moal
Western Digital Research
