Re: [PATCH 1/9] scsi: flip the default on use_clustering

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2018-12-06 at 07:52 -0800, Christoph Hellwig wrote:
+AD4 Most SCSI drivers want to enable +ACI-clustering+ACI, that is merging of
+AD4 segments so that they might span more than a single page.  Remove the
+AD4 ENABLE+AF8-CLUSTERING define, and require drivers to explicitly set
+AD4 DISABLE+AF8-CLUSTERING to disable this feature.  All drivers not setting
+AD4 use+AF8-clustering at all are switched to set DISABLE+AF8-CLUSTERING to keep
+AD4 the current behavior.

Was this patch produced manually or has it been generated with the help
of a script? In the latter case it would help if that script would be
included in the patch description.

Additionally, this patch would be much easier to review if it would be
split into two patches, one that adds .use+AF8-clustering +AD0 DISABLE+AF8-CLUSTERING
from SCSI templates that implicitly disable clustering and a second patch
that removes .use+AF8-clustering +AD0 ENABLE+AF8-CLUSTERING from all SCSI drivers.

Thanks,

Bart.



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux