On 11/14/18 8:12 PM, Jianchao Wang wrote: > Hi Jens > > Please consider this patchset for 4.21. > It refactors the code of issue request directly to unify the interface > and make the code clearer and more readable. > > The 1st patch refactors the code of issue request directly to unify the > helper interface which could handle all the cases. > > The 2nd patch make blk_mq_sched_insert_requests issue requests directly > with 'bypass' false, then it needn't to handle the non-issued requests > any more. > > The 3rd patch replace and kill the blk_mq_request_issue_directly. I'd love to get this queued up, the direct dispatch path is a mess and it's even now been known to cause corruptions... I'm going to queue up the direct dispatch fix shortly, and apply it to for-4.21/block as well. Any chance you can respin this on top after that? -- Jens Axboe