Re: [PATCH 02/13] nvme-pci: use atomic bitops to mark a queue enabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




@@ -2173,6 +2157,8 @@ static int nvme_setup_io_queues(struct nvme_dev *dev)
     	if (nr_io_queues == 0)
   		return 0;
+	
+	clear_bit(NVMEQ_ENABLED, &adminq->flags);

This is a change of behavior, looks correct though as we can fail
nvme_setup_irqs after we freed the admin vector. Needs documentation
though..

I have a hard time parsing the above, can you point to where the problem
is?

This flag replaces cq_vector = -1 for indicating the queue state so I'd
expect that it would not appear where the former didn't. In this case
we clear the flag in a place that before we did not set the cq_vector
before, which seems correct to me though.



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux