Re: [PATCH 05/13] nvme-pci: consolidate code for polling non-dedicated queues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Sagi Grimberg <sagi@xxxxxxxxxxx>
Subject: Re: [PATCH 05/13] nvme-pci: consolidate code for polling non-dedicated queues
From: Christoph Hellwig <hch@xxxxxx>
Date: Tue, 4 Dec 2018 16:04:49 +0100
Cc: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxx>, Keith Busch <keith.busch@xxxxxxxxx>, Max Gurtovoy <maxg@xxxxxxxxxxxx>, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx
In-reply-to: <9abd8fde-58c4-0704-1e42-d066b674bb90@grimberg.me>
References: <20181202164628.1116-1-hch@lst.de> <20181202164628.1116-6-hch@lst.de> <9abd8fde-58c4-0704-1e42-d066b674bb90@grimberg.me>
User-agent: Mutt/1.5.17 (2007-11-01)

On Mon, Dec 03, 2018 at 04:58:25PM -0800, Sagi Grimberg wrote:
>
>> +static int nvme_poll_irqdisable(struct nvme_queue *nvmeq, unsigned int tag)
>
> Do we still need to carry the tag around?

Yes, the timeout handler polls for a specific tag.

Follow-Ups:
- Re: [PATCH 05/13] nvme-pci: consolidate code for polling non-dedicated queues
  - From: Sagi Grimberg

References:
- block and nvme polling improvements V3
  - From: Christoph Hellwig
- [PATCH 05/13] nvme-pci: consolidate code for polling non-dedicated queues
  - From: Christoph Hellwig
- Re: [PATCH 05/13] nvme-pci: consolidate code for polling non-dedicated queues
  - From: Sagi Grimberg

Prev by Date: Re: [PATCH 02/13] nvme-pci: use atomic bitops to mark a queue enabled
Next by Date: Re: [PATCH 06/13] nvme-pci: refactor nvme_disable_io_queues
Previous by thread: Re: [PATCH 05/13] nvme-pci: consolidate code for polling non-dedicated queues
Next by thread: Re: [PATCH 05/13] nvme-pci: consolidate code for polling non-dedicated queues
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]