On Fri, 2018-11-30 at 10:08 -0700, Jens Axboe wrote: +AD4 On 11/30/18 10:07 AM, Bart Van Assche wrote: +AD4 +AD4 On Fri, 2018-11-30 at 09:56 -0700, Jens Axboe wrote: +AD4 +AD4 +AD4 If the ioprio capability check fails, we return without putting +AD4 +AD4 +AD4 the file pointer. +AD4 +AD4 +AD4 +AD4 +AD4 +AD4 Fixes: d9a08a9e616b (+ACI-fs: Add aio iopriority support+ACI) +AD4 +AD4 +AD4 Reviewed-by: Johannes Thumshirn +ADw-jthumshirn+AEA-suse.de+AD4 +AD4 +AD4 +AD4 Reviewed-by: Christoph Hellwig +ADw-hch+AEA-lst.de+AD4 +AD4 +AD4 +AD4 Signed-off-by: Jens Axboe +ADw-axboe+AEA-kernel.dk+AD4 +AD4 +AD4 +AD4 --- +AD4 +AD4 +AD4 fs/aio.c +AHw 1 +- +AD4 +AD4 +AD4 1 file changed, 1 insertion(+-) +AD4 +AD4 +AD4 +AD4 +AD4 +AD4 diff --git a/fs/aio.c b/fs/aio.c +AD4 +AD4 +AD4 index b984918be4b7..205390c0c1bb 100644 +AD4 +AD4 +AD4 --- a/fs/aio.c +AD4 +AD4 +AD4 +-+-+- b/fs/aio.c +AD4 +AD4 +AD4 +AEAAQA -1436,6 +-1436,7 +AEAAQA static int aio+AF8-prep+AF8-rw(struct kiocb +ACo-req, struct iocb +ACo-iocb) +AD4 +AD4 +AD4 ret +AD0 ioprio+AF8-check+AF8-cap(iocb-+AD4-aio+AF8-reqprio)+ADs +AD4 +AD4 +AD4 if (ret) +AHs +AD4 +AD4 +AD4 pr+AF8-debug(+ACI-aio ioprio check cap error: +ACU-d+AFw-n+ACI, ret)+ADs +AD4 +AD4 +AD4 +- fput(req-+AD4-ki+AF8-filp)+ADs +AD4 +AD4 +AD4 return ret+ADs +AD4 +AD4 +AD4 +AH0 +AD4 +AD4 +AD4 +AD4 Since this patch fixes a bug that was introduced in kernel v4.18, does this +AD4 +AD4 patch need a +ACI-Cc: stable+ACI tag? +AD4 +AD4 The fixes should take care of that by itself, I hope. Hi Jens, My understanding is that patches that have a +ACI-Cc: stable+ACI tag are guaranteed to be integrated in a stable kernel sooner or later. Without that tag it depends on the stable kernel maintainer whether or not these patches get picked up. I think the +ACI-AUTOSEL+ACI tag Sasha Levin uses indicates that a patch was picked up for one of his stable kernels and that it did not have a +ACI-Cc: stable+ACI tag. I'm not sure Greg KH picks up patches that only have a +ACI-Fixes:+ACI tag but no +ACI-Cc: stable+ACI tag. Bart.
