On 11/29/18 8:47 AM, Christoph Hellwig wrote: >> +static inline int nvme_next_ring_index(struct nvme_queue *nvmeq, u16 index) >> +{ >> + if (++index == nvmeq->q_depth) >> + return 0; >> + >> + return index; >> +} > > This is unused now. Huh, wonder how I missed that. GCC must not have complained. > Also what about this little cleanup on top? That looks good, I like it. With that, can I add your reviewed-by? I'll run a sanity check on it first. -- Jens Axboe