On Thu, Nov 29, 2018 at 07:49:59AM -0800, Christoph Hellwig wrote: > > + /* > > + * Use plugging if we have a ->commit_rqs() hook as well, > > + * as we know the driver uses bd->last in a smart > > + * fashion. > > + */ > > Nipick: this could flow on just two lines: > > /* > * Use plugging if we have a ->commit_rqs() hook as well, as we > * know the driver uses bd->last in a smart fashion. > */ But of course otherwise this looks fine: Reviewed-by: Christoph Hellwig <hch@xxxxxx>