On 11/26/18 1:16 AM, Christoph Hellwig wrote: >> -bool blk_poll(struct request_queue *q, blk_qc_t cookie) >> +int blk_poll(struct request_queue *q, blk_qc_t cookie) > > Can you add a comment explaining the return value? > >> { >> if (!q->poll_fn || !blk_qc_t_valid(cookie)) >> return false; > > And false certainly isn't an integer constant.. Done -- Jens Axboe