On Wed, Nov 21, 2018 at 02:19:28PM +0100, Christoph Hellwig wrote:
> On Wed, Nov 21, 2018 at 11:23:10AM +0800, Ming Lei wrote:
> > This patch introduces helpers of 'segment_iter_*' for multipage
> > bvec support.
> >
> > The introduced helpers treate one bvec as real multi-page segment,
> > which may include more than one pages.
>
> Unless I'm missing something these bvec vs segment names are exactly
> inverted vs how we use it elsewhere.
>
> In the iterators we use segment for single-page bvec, and bvec for multi
> page ones, and here it is inverse. Please switch it around.
bvec_iter_* is used for single-page bvec in current linus tree, and there are
lots of users now:
[linux]$ git grep -n "bvec_iter_*" ./ | wc
191 995 13242
If we have to switch it first, it can be a big change, just wondering if Jens
is happy with that?
Thanks,
Ming
