On Mon, Nov 19, 2018 at 07:00:09PM -0800, Sagi Grimberg wrote: > From: Sagi Grimberg <sagi@xxxxxxxxxxxxxxxxx> > > connect_work and err_work will be reused by nvme-tcp so > share those in nvme_ctrl for rdma and fc to share. As said before when you sent this invididually: I'd rather not move struct members to the common struture until we actually start using it there. So for now please add it to the containing TCP-specific structure, although I'm looking forward to actually see code around it consolidated eventually.