Re: [PATCH 03/11] blk-rq-qos: inline check for q->rq_qos functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 15, 2018 at 12:51:27PM -0700, Jens Axboe wrote:
> Put the short code in the fast path, where we don't have any
> functions attached to the queue. This minimizes the impact on
> the hot path in the core code.

This looks mechanically fine:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

But since I seem to have missed the introduction of it - why do we need
multiple struct rq_qos per request to start with?  This sort of stacking
seems rather odd and counter-productive, and the commit introducing
this code doesn't explain the rationale at all.



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux