On 11/14/18 8:40 AM, Christoph Hellwig wrote: > On Wed, Nov 14, 2018 at 08:33:33AM -0700, Jens Axboe wrote: >>> The inlining sounds fine, but please do it without the obsfucating >>> macros. >> >> Why? It's a lot of code duplication. > > Just source code, not binary code. And remember that humans want > to understand this code by grepping it, finding it in source browsers, > etc. And all that macro obsfucation makes it much harder. I've changed it to just spell them all out. -- Jens Axboe
