Re: [PATCH V5 1/6] blk-mq: make __blk_mq_issue_directly be able to accept NULL cookie pointer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Jianchao Wang <jianchao.w.wang@xxxxxxxxxx>
Subject: Re: [PATCH V5 1/6] blk-mq: make __blk_mq_issue_directly be able to accept NULL cookie pointer
From: Jens Axboe <axboe@xxxxxxxxx>
Date: Mon, 12 Nov 2018 10:10:16 -0700
Cc: ming.lei@xxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <1542014609-1769-2-git-send-email-jianchao.w.wang@oracle.com>
References: <1542014609-1769-1-git-send-email-jianchao.w.wang@oracle.com> <1542014609-1769-2-git-send-email-jianchao.w.wang@oracle.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

On 11/12/18 2:23 AM, Jianchao Wang wrote:
> Make __blk_mq_issue_directly be able to accept a NULL cookie pointer
> and remove the dummy unused_cookie in blk_mq_request_issue_directly.

What's the reasoning behind this? Seems faster to store the cookie
always, instead of introducing a branch to the hot path.

-- 
Jens Axboe

Follow-Ups:
- Re: [PATCH V5 1/6] blk-mq: make __blk_mq_issue_directly be able to accept NULL cookie pointer
  - From: jianchao.wang

References:
- [PATCH V5 0/6] blk-mq: refactor and fix on issue request directly
  - From: Jianchao Wang
- [PATCH V5 1/6] blk-mq: make __blk_mq_issue_directly be able to accept NULL cookie pointer
  - From: Jianchao Wang

Prev by Date: Re: kobject lifetime issues in blk-mq
Next by Date: Re: [PATCH v3] block: copy ioprio in __bio_clone_fast()
Previous by thread: [PATCH V5 1/6] blk-mq: make __blk_mq_issue_directly be able to accept NULL cookie pointer
Next by thread: Re: [PATCH V5 1/6] blk-mq: make __blk_mq_issue_directly be able to accept NULL cookie pointer
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]