Re: [PATCH blktests] fix discontiguous-io compile error on 32 bit systems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2018-11-01 at 14:35 +-0800, Yufen Yu wrote:
+AD4 When make discontiguous-io.cpp with -m32, g+-+- compiler reports
+AD4 error for std::min(long unsigned int, size+AF8-t) has diffent
+AD4 arguments type.
+AD4 
+AD4 fixes: fd21728886e7 (+ACI-Add the discontiguous-io test program+ACI)
+AD4 Signed-off-by: Yufen Yu +ADw-yuyufen+AEA-huawei.com+AD4
+AD4 ---
+AD4  src/discontiguous-io.cpp +AHw 2 +--
+AD4  1 file changed, 1 insertion(+-), 1 deletion(-)
+AD4 
+AD4 diff --git a/src/discontiguous-io.cpp b/src/discontiguous-io.cpp
+AD4 index 5e0ee0f..855aba9 100644
+AD4 --- a/src/discontiguous-io.cpp
+AD4 +-+-+- b/src/discontiguous-io.cpp
+AD4 +AEAAQA -291,7 +-291,7 +AEAAQA int main(int argc, char +ACoAKg-argv)
+AD4  			unsigned char +ACo-p +AD0 +ACYAKg-buf.begin()+ADs
+AD4  			for (int i +AD0 0+ADs i +ADw len / 4+ADs i+-+-)
+AD4  				iov.append(p +- 4 +- i +ACo 8,
+AD4 -					   std::min(4ul, len - i +ACo 4))+ADs
+AD4 +-					   std::min((size+AF8-t)4, len - i +ACo 4))+ADs
+AD4  		+AH0 else +AHs
+AD4  			iov.append(+ACYAKg-buf.begin(), buf.size())+ADs
+AD4  		+AH0

Are you reading the messages posted on linux-block? An alternative that I like
better has been discussed in this e-mail thread:
https://www.spinics.net/lists/linux-block/msg32181.html

Bart.



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux