Re: [PATCH] block: call rq_qos_exit() after queue is frozen

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ming Lei <ming.lei@xxxxxxxxxx>
Subject: Re: [PATCH] block: call rq_qos_exit() after queue is frozen
From: Jens Axboe <axboe@xxxxxxxxx>
Date: Wed, 31 Oct 2018 08:40:54 -0600
Cc: linux-block@xxxxxxxxxxxxxxx, Josef Bacik <josef@xxxxxxxxxxxxxx>
In-reply-to: <20181024131809.23070-1-ming.lei@redhat.com>
References: <20181024131809.23070-1-ming.lei@redhat.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

On 10/24/18 7:18 AM, Ming Lei wrote:
> rq_qos_exit() removes the current q->rq_qos, this action has to be
> done after queue is frozen, otherwise the IO queue path may never
> be waken up, then IO hang is caused.
> 
> So fixes this issue by moving rq_qos_exit() after queue is frozen.

Looks good, thanks. Applied for 4.20.

-- 
Jens Axboe

References:
- [PATCH] block: call rq_qos_exit() after queue is frozen
  - From: Ming Lei

Prev by Date: Re: [PATCH 14/16] nvme: utilize two queue maps, one for reads and one for writes
Next by Date: Re: [PATCH] block: brd: associate with queue until adding disk
Previous by thread: Re: [PATCH] block: call rq_qos_exit() after queue is frozen
Next by thread: [PATCH BUGFIX] block, bfq: fix asymmetric scenarios detection
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]

Powered by Linux