On Tue, 2018-10-30 at 12:02 -0400, Theodore Y. Ts'o wrote: +AD4 On Tue, Oct 30, 2018 at 08:02:55AM -0700, Bart Van Assche wrote: +AD4 +AD4 Details about how the build fails on 32-bit systems would have been welcome +AD4 +AD4 in the commit message. Anyway: +AD4 +AD4 +AD4 +AD4 Reviewed-by: Bart Van Assche +ADw-bvanassche+AEA-acm.org+AD4 +AD4 +AD4 For the record, here's the failure. It's the usual incomprehensible +AD4 C+-+- error reporting. :-) +AD4 +AD4 +AFs ... +AF0 +AD4 discontiguous-io.cpp: In function 'int main(int, char+ACoAKg)': +AD4 discontiguous-io.cpp:294:34: error: no matching function for call to 'min(long unsigned int, size+AF8-t)' +AD4 std::min(4ul, len - i +ACo 4))+ADs +AD4 +AF4 +AD4 +AFs ... +AF0 Thanks Ted for having provided the full compiler output. However, I don't think that the entire error message should go in the commit message. To me, the part of the compiler error message I cited tells the whole story :-) Bart.
