Re: [PATCH 01/14] blk-mq: kill q->mq_map

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 25, 2018 at 03:16:13PM -0600, Jens Axboe wrote:
>  static inline struct blk_mq_hw_ctx *blk_mq_map_queue(struct request_queue *q,
>  		int cpu)
>  {
> -	return q->queue_hw_ctx[q->mq_map[cpu]];
> +	struct blk_mq_tag_set *set = q->tag_set;
> +
> +	return q->queue_hw_ctx[set->mq_map[cpu]];

Nitpick: this would be a little more readable without the local
set variable:

	return q->queue_hw_ctx[q->tag_set->mq_map[cpu]];

Otherwise this looks good to me:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux