On 10/27/18 10:48 AM, Jens Axboe wrote: > On 10/27/18 8:19 AM, jianchao.wang wrote: >> Hi Jens >> >> On 10/26/18 5:16 AM, Jens Axboe wrote: >>> It's just a pointer to set->mq_map, use that instead. >> Instead of using the set->mq_map and then a two-dimensional set->mq_map, >> how about migrate the mq_map from per-set to per-cpuctx ? >> something like: >> q->queue_hw_ctx[ctx->map[type]] > > I think the current series is pretty clean in that regard, it goes > from members -> map -> map array. I'd be willing to look at a > conversion on top of that, if it makes things cleaner. On top of that, this: q->queue_hw_ctx[set->map[type].mq_map[cpu]] is one less pointer dereference, so more efficient. -- Jens Axboe
