Re: [PATCH 1/3] block: make sure discard bio is aligned with logical block size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ming Lei <ming.lei@xxxxxxxxxx>
Subject: Re: [PATCH 1/3] block: make sure discard bio is aligned with logical block size
From: Christoph Hellwig <hch@xxxxxx>
Date: Fri, 26 Oct 2018 09:44:15 +0200
Cc: Jens Axboe <axboe@xxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, Rui Salvaterra <rsalvaterra@xxxxxxxxx>, stable@xxxxxxxxxxxxxxx, Mike Snitzer <snitzer@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Xiao Ni <xni@xxxxxxxxxx>, Mariusz Dabrowski <mariusz.dabrowski@xxxxxxxxx>
In-reply-to: <20181026062435.21398-2-ming.lei@redhat.com>
References: <20181026062435.21398-1-ming.lei@redhat.com> <20181026062435.21398-2-ming.lei@redhat.com>
User-agent: Mutt/1.5.17 (2007-11-01)

>  		if (req_sects > UINT_MAX >> 9)
> -			req_sects = UINT_MAX >> 9;
> +			req_sects = (UINT_MAX >> 9) & ~bs_mask;

Given that we have this same thing duplicated in write zeroes
what about a documented helper?

Follow-Ups:
- Re: [PATCH 1/3] block: make sure discard bio is aligned with logical block size
  - From: Ming Lei

References:
- [PATCH 0/3] block: make sure discard/writesame bio is aligned with logical block size
  - From: Ming Lei
- [PATCH 1/3] block: make sure discard bio is aligned with logical block size
  - From: Ming Lei

Prev by Date: Re: [PATCH 05/28] IB/srp: remove old request_fn_active check
Next by Date: Re: [PATCH 2/3] block: cleanup __blkdev_issue_discard()
Previous by thread: [PATCH 1/3] block: make sure discard bio is aligned with logical block size
Next by thread: Re: [PATCH 1/3] block: make sure discard bio is aligned with logical block size
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]