On 10/25/18 3:23 PM, Bart Van Assche wrote:
> On Thu, 2018-10-25 at 15:10 -0600, Jens Axboe wrote:
>> This check is only viable for non scsi-mq. Since that is going away,
>> kill this legacy check.
>>
>> Cc: Bart Van Assche <bvanassche@xxxxxxx>
>> Cc: Parav Pandit <parav@xxxxxxxxxxxx>
>> Cc: linux-scsi@xxxxxxxxxxxxxxx
>> Signed-off-by: Jens Axboe <axboe@xxxxxxxxx>
>> ---
>> drivers/infiniband/ulp/srp/ib_srp.c | 7 -------
>> 1 file changed, 7 deletions(-)
>>
>> diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
>> index 0b34e909505f..5a79444c2f3c 100644
>> --- a/drivers/infiniband/ulp/srp/ib_srp.c
>> +++ b/drivers/infiniband/ulp/srp/ib_srp.c
>> @@ -1334,13 +1334,6 @@ static void srp_terminate_io(struct srp_rport *rport)
>> struct scsi_device *sdev;
>> int i, j;
>>
>> - /*
>> - * Invoking srp_terminate_io() while srp_queuecommand() is running
>> - * is not safe. Hence the warning statement below.
>> - */
>> - shost_for_each_device(sdev, shost)
>> - WARN_ON_ONCE(sdev->request_queue->request_fn_active);
>> -
>> for (i = 0; i < target->ch_count; i++) {
>> ch = &target->ch[i];
>
> It seems like Hannes' and my Signed-off-by/Reviewed-by tags are missing?
> See also https://marc.info/?l=linux-scsi&m=153970174514608.
Sorry, forgot to update that one. I'll do that for v2. Thanks for letting
me know.
--
Jens Axboe
