Re: [PATCH 1/3] myrb: Add Mylex RAID controller (block interface)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 99d366cb0e9f..1efbd175411a 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -922,10 +922,12 @@
>  #define PCI_DEVICE_ID_PICOPOWER_PT86C523BBP	0x8002
>  
>  #define PCI_VENDOR_ID_MYLEX		0x1069
> +#define PCI_SUBVENDOR_ID_MYLEX		0x1069

Vendor and subvendor its are the same.  Just use PCI_VENDOR_ID_MYLEX
where you;d want to use PCI_SUBVENDOR_ID_MYLEX.

>  #define PCI_DEVICE_ID_MYLEX_DAC960_P	0x0001
>  #define PCI_DEVICE_ID_MYLEX_DAC960_PD	0x0002
>  #define PCI_DEVICE_ID_MYLEX_DAC960_PG	0x0010
>  #define PCI_DEVICE_ID_MYLEX_DAC960_LA	0x0020
> +#define PCI_SUBDEVICE_ID_MYLEX_DAC960_LA 0x0020

Same here, in addition to the fact that we really don't
want single use PCI IDs in pci_ids.h.

Bonous points for just using the numeric values in the driver, and
adding another patch to remove them from pci_ids.h.

Otherwise looks fine to me:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux