On Tue, Oct 02, 2018 at 09:43:35AM +0000, Ioana Ciornei wrote: > > > Add BUS_ATTR_WO macro to make it easier to add attributes without > > > auditing the mode settings. Also, use the newly added macro where > > > appropriate. > > > > > > Signed-off-by: Ioana Ciornei <ioana.ciornei@xxxxxxx> > > > --- > > > arch/powerpc/platforms/pseries/ibmebus.c | 12 ++++---- > > > drivers/block/rbd.c | 48 ++++++++++++++++---------------- > > > drivers/scsi/fcoe/fcoe_sysfs.c | 4 +-- > > > drivers/scsi/fcoe/fcoe_transport.c | 10 +++---- > > > include/linux/device.h | 2 ++ > > > include/scsi/libfcoe.h | 8 +++--- > > > 6 files changed, 43 insertions(+), 41 deletions(-) > > > > Nice! This duplicates a lot of the work I did back in July but have not pushed out > > very far due to the other things that ended up happening around that time: > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/log/?h=bus_cleanup > > > > As the patch series seen at that link shows, you can do this in more places than > > just what you did here. > > > > Either way, you should break this up into the individual patches, like I did or you > > can take my patches if you want. Getting the BUS_ATTR_WO() macro added is > > good to do now, and then you can go and hit up all of the different subsystems > > that should be converted over to it. > > I can of course split my patch into individual ones and resubmit them, but as you already have the entire patch set ready, I feel like we can just push those. I looked through your changes and it seems like you covered all the subsystems. Please let me know if there is something else I should do. > > My intention here was to first add the _WO attribute so that afterwards I can add a new bus attribute in the fsl-mc bus. Ok, I've queued up the patch that adds the _WO attribute now, so that you should be able to use this after 4.20-rc1. I'll work on getting my other patches merged in that series at that time as well. thanks, greg k-h
