On 10/15/18 8:19 AM, Jens Axboe wrote: > On 10/15/18 4:38 AM, Ming Lei wrote: >>> @@ -320,7 +320,7 @@ static void vdc_end_one(struct vdc_port *port, struct vio_dring_state *dr, >>> >>> rqe->req = NULL; >>> >>> - __blk_end_request(req, (desc->status ? BLK_STS_IOERR : 0), desc->size); >>> + blk_mq_end_request(req, desc->status ? BLK_STS_IOERR : 0); >> >> blk_mq_end_request() may trigger BUG in case of partial completion, >> however looks it is fine for __blk_end_request(). > > True, I'll change this to the blk_update_request() + > __blk_mq_end_request() combo instead. I take that back, it's correct as is. This isn't a partial completion, it's completing the request. The BUG() inside blk_mq_end_request() would indicate a bug in the internal code, we don't expect a not-done return when we ask to complete the whole thing. -- Jens Axboe
