(resend - managed to lose $subject, sorry)
Am 14.10.2018 um 17:48 schrieb Michael Schmitz:
and yet another new version of the Amiga RDB partition table patch.
I've split off the part fixing the incorrect use of signed int
for partition start address and size as separate patch. It does fix the
bug that Martin Steigerwald reported six years ago for a 2 TB disk.
I have tested this patch with the identical RDB partition data that
Martin saw the bug with. I have incorporated Andreas' feedback on proper
use of casts to avoid integer overflow in this version.
The simple fix still leaves ample room for overflows in calculating start
address and size of a RDB partition, though such overflows should only be
seen in rather unusual cases. To address these potential overflows, checks
are added in the second patch of this series. Again, misuse of casts have
been corrected, and yet another (highly unlikely) potential 32 bit
multiplication overflow caused by use of signed int instead of sector
(spotted by Geert Uytterhoeven) has been fixed and a check has been added
in this version.
I've added Geert's Reviewed-by tag to patch 1,as there were no further
changes to that patch.
Cheers,
Michael
