On Fri, Oct 12, 2018 at 12:23 PM Jens Axboe <axboe@xxxxxxxxx> wrote: > > On 10/12/18 10:17 AM, Ed Cashin wrote: > > On Fri, Oct 12, 2018 at 10:20 AM Jens Axboe <axboe@xxxxxxxxx> wrote: > >> > >> On 10/12/18 5:28 AM, Ed Cashin wrote: > >>> OK. We always tried to avoid putting includes in the .h file, so > >>> if you wouldn't mind moving the include to the C files, that would > >>> be nice. I wouldn't insist, though. > >> > >> There's really no way around it, since I'm embedding the tag_set > >> in the device. > >> > >> Is that OK with you? > > > > Yes, it's fine. Thank you. > > Can I add a reviewed-by? Acked-by is already fine, but I can give it more attention tomorrow, and after that a reviewed-by would be appropriate. -- Ed
