Re: [PATCH v3 09/11] block: Expose queue nr_zones in sysfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 12, 2018 at 09:41:28AM +0200, Hannes Reinecke wrote:
>> +{
>> +	return 0;
>> +}
>>   #endif /* CONFIG_BLK_DEV_ZONED */
>>     static inline bool rq_is_sync(struct request *rq)
>>
> Actually, we should be checking whether we can't blank out this attribute 
> via the is_visible mechanism; after all, not every block device is zoned, 
> and those which are not have no need of the attribute...

The answer would be 0 in this case.  I'm not sure blanking out is worth
it as it will create a lot more code for very little gain..



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux