Re: [PATCH 12/13] floppy: end whole request on error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Omar Sandoval <osandov@xxxxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx
Subject: Re: [PATCH 12/13] floppy: end whole request on error
From: Jens Axboe <axboe@xxxxxxxxx>
Date: Thu, 11 Oct 2018 12:39:51 -0600
Cc: kernel-team@xxxxxx
In-reply-to: <4b575ac74fab6d233b891f8c12dadaea3873931c.1539282366.git.osandov@fb.com>
References: <cover.1539282366.git.osandov@fb.com> <4b575ac74fab6d233b891f8c12dadaea3873931c.1539282366.git.osandov@fb.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0

On 10/11/18 12:30 PM, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@xxxxxx>
> 
> If floppy_end_request() gets passed an error, it should end the whole
> request, not just the current segment.

I don't think this is correct, we should still just end the
individual chunks.

-- 
Jens Axboe

Follow-Ups:
- Re: [PATCH 12/13] floppy: end whole request on error
  - From: Omar Sandoval

References:
- [PATCH 00/13] Convert floppy drivers to blk-mq
  - From: Omar Sandoval
- [PATCH 12/13] floppy: end whole request on error
  - From: Omar Sandoval

Prev by Date: [PATCH 13/13] floppy: convert to blk-mq
Next by Date: Re: [PATCH 12/13] floppy: end whole request on error
Previous by thread: [PATCH 12/13] floppy: end whole request on error
Next by thread: Re: [PATCH 12/13] floppy: end whole request on error
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]

Powered by Linux