On 10/8/18 9:02 AM, Coly Li wrote: > On 2018/10/8 下午10:19, Jens Axboe wrote: >> On 10/8/18 6:41 AM, Coly Li wrote: >>> From: Ben Peddell <klightspeed@xxxxxxxxxxxxxxxx> >>> >>> Forgot to include the maintainers with my first email. >>> >>> Somewhere between Michael Lyle's original >>> "bcache: PI controller for writeback rate V2" patch dated 07 Sep 2017 >>> and 1d316e6 bcache: implement PI controller for writeback rate, >>> the mapping of the writeback_rate_minimum attribute was dropped. >>> >>> Re-add the missing sysfs writeback_rate_minimum attribute mapping to >>> "allow the user to specify a minimum rate at which dirty blocks are >>> retired." >>> >>> Fixes: 1d316e6 bcache: implement PI controller for writeback rate >> >> Remember to use the correct format for the Fixes line. >> > > Hi Jens, > > This is my fault, it slips from my eyes. I'd like to resend a fixed up > version to you. I fixed it up when I applied it. > BTW, now I only use checkpatches.pl to check patch format, do you use > extra scripts as format checking hooks ? I don't use checkpatch, I just use my eye balls :-) -- Jens Axboe