Re: [PATCH v10 7/8] block: Make blk_get_request() block for non-PM requests while suspended

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Johannes Thumshirn <jthumshirn@xxxxxxx>
Subject: Re: [PATCH v10 7/8] block: Make blk_get_request() block for non-PM requests while suspended
From: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 26 Sep 2018 16:57:32 +0200
Cc: Christoph Hellwig <hch@xxxxxx>, Bart Van Assche <bvanassche@xxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, Ming Lei <ming.lei@xxxxxxxxxx>, Jianchao Wang <jianchao.w.wang@xxxxxxxxxx>, Hannes Reinecke <hare@xxxxxxxx>, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
In-reply-to: <20180926144357.GC13588@linux-x5ow.site>
References: <20180921203122.49743-1-bvanassche@acm.org> <20180921203122.49743-8-bvanassche@acm.org> <20180926142740.GE8604@lst.de> <20180926144357.GC13588@linux-x5ow.site>
User-agent: Mutt/1.5.17 (2007-11-01)

On Wed, Sep 26, 2018 at 04:43:57PM +0200, Johannes Thumshirn wrote:
> > assert, so I guess we'll have to live with it..
> 
> How about:
> 			if (IS_ENABLED(CONFIG_PM))
> 			   WARN_ON_ONCE(q->rpm_status == RPM_SUSPENDED);

I don't think this actually works given that rpm_status only exists
if CONFIG_PM is set.

Follow-Ups:
- Re: [PATCH v10 7/8] block: Make blk_get_request() block for non-PM requests while suspended
  - From: Johannes Thumshirn

References:
- [PATCH v10 0/8] blk-mq: Implement runtime power management
  - From: Bart Van Assche
- [PATCH v10 7/8] block: Make blk_get_request() block for non-PM requests while suspended
  - From: Bart Van Assche
- Re: [PATCH v10 7/8] block: Make blk_get_request() block for non-PM requests while suspended
  - From: Christoph Hellwig
- Re: [PATCH v10 7/8] block: Make blk_get_request() block for non-PM requests while suspended
  - From: Johannes Thumshirn

Prev by Date: Re: clean up physical merging helpers
Next by Date: Re: [PATCH v10 7/8] block: Make blk_get_request() block for non-PM requests while suspended
Previous by thread: Re: [PATCH v10 7/8] block: Make blk_get_request() block for non-PM requests while suspended
Next by thread: Re: [PATCH v10 7/8] block: Make blk_get_request() block for non-PM requests while suspended
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]