Re: [PATCH v10 3/8] block: Split blk_pm_add_request() and blk_pm_put_request()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

But one very minor nitpick below:

>  #ifdef CONFIG_PM
> +static inline void blk_pm_request_resume(struct request_queue *q)
> +{
> +	if (q->dev && (q->rpm_status == RPM_SUSPENDED ||
> +		       q->rpm_status == RPM_SUSPENDING))

I usually try to break lines around related conditions, so more something
like:

	if (q->dev &&
	    (q->rpm_status == RPM_SUSPENDED || q->rpm_status == RPM_SUSPENDING))



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux