Bart, > The RQF_PREEMPT flag is used for three purposes: > - In the SCSI core, for making sure that power management requests > are executed even if a device is in the "quiesced" state. > - For domain validation by SCSI drivers that use the parallel port. > - In the IDE driver, for IDE preempt requests. > Rename "preempt-only" into "pm-only" because the primary purpose of > this mode is power management. Since the power management core may but > does not have to resume a runtime suspended device before performing > system-wide suspend and since a later patch will set "pm-only" mode as > long as a block device is runtime suspended, make it possible to set > "pm-only" mode from more than one context. Since with this change > scsi_device_quiesce() is no longer idempotent, make that function > return early if it is called for a quiesced queue. The SCSI pieces look OK to me... Acked-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx> -- Martin K. Petersen Oracle Linux Engineering